Gentoo Archives: gentoo-dev

From: "Justin (jlec)" <jlec@g.o>
To: gentoo-dev@l.g.o, grknight@g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-db/mysql: mysql-5.1.73-r1.ebuild ChangeLog mysql-5.1.73.ebuild
Date: Wed, 14 May 2014 06:56:54
Message-Id: 537313AB.6010805@gentoo.org
1 On 14/05/14 03:47, Brian Evans (grknight) wrote:
2
3 Hi Brian,
4
5 > EAPI="4"
6
7 please always try to bump to latest EAPI when ever you add a new
8 revision or version to the tree,
9
10
11 > # Most of these are in the eclass
12 > DEPEND="|| ( >=sys-devel/gcc-3.4.6 >=sys-devel/gcc-apple-4.0 )
13 > >=sys-devel/libtool-2.2.10"
14
15 As you wrote correctly in your quizzes, depending is not enough. You
16 also need to test to those compilers.
17
18 > src_prepare() {
19 > sed -i \
20 > -e '/^noinst_PROGRAMS/s/basic-t//g' \
21 > "${S}"/unittest/mytap/t/Makefile.am
22
23 missing die for external tools.
24
25 > emake check || die "make check failed"
26
27 no die needed for emake in higher EAPIs.
28
29 > cd "${S}"
30
31 same here
32
33 > # create directories because mysqladmin might make out of order
34 > mkdir -p "${S}"/mysql-test/var-{ps,ns}{,/log}
35
36 here
37
38
39
40 Justin

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies