Gentoo Archives: gentoo-dev

From: "Marty E. Plummer" <hanetzer@×××××××××.com>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [PATCH 3/5] xdg.eclass: move deps to RDEPEND
Date: Tue, 02 Oct 2018 02:19:18
Message-Id: 20181002021437.rf5ldh4wlciktd7n@proprietary-killer
In Reply to: Re: [gentoo-dev] Re: [PATCH 3/5] xdg.eclass: move deps to RDEPEND by Mike Gilbert
1 On Mon, Oct 01, 2018 at 10:08:03AM -0400, Mike Gilbert wrote:
2 > On Mon, Oct 1, 2018 at 9:17 AM James Le Cuirot <chewi@g.o> wrote:
3 > >
4 > > On Mon, 1 Oct 2018 09:00:38 -0400
5 > > Mike Gilbert <floppym@g.o> wrote:
6 > >
7 > > > > The reason why it is in DEPEND though is that none of these tools
8 > > > > are required at runtime. They are needed at postinst and postrm
9 > > > > stages which afaik makes them DEPEND on EAPI previous to EAPI 7 and
10 > > > > BDEPEND in EAPI 7 if I'm not mistaken.
11 > > >
12 > > > This is incorrect; programs executed in pkg_postinst/pkg_postrm should
13 > > > be present in RDEPEND. Consider a binpkg installation, which would
14 > > > ignore DEPEND, but would still execute pkg_postinst.
15 > > >
16 > > > Another option: since xdg-utils.eclass functions will politely skip
17 > > > the updates if the tools are missing, we could just drop the
18 > > > dependency from xdg.eclass entirely and wait for the tools to get
19 > > > installed through some indirect means.
20 > >
21 > > Unfortunately there is no correct answer here as we didn't consider
22 > > this scenario when planning EAPI 7. We should have looked at Exherbo,
23 > > which does make this important distinction. There is a bug report open.
24 > >
25 > > https://bugs.gentoo.org/660306
26 > >
27 > > What I will say is that we should not attempt to executing anything
28 > > from within ROOT or SYSROOT unless it known to be interpreted
29 > > (e.g. a shell script) and there is no feasible alternative. I add that
30 > > exclusion clause because I have been forced to do this with
31 > > python-config.
32 >
33 > That's a good point; both update-desktop-database and
34 > update-mime-database are compiled binaries, and should probably be
35 > executed from BROOT (/) instead. I'll revise my patchset.
36 >
37 Not to steal the show/etc, but I do have a patchset which does most of
38 this already across {gnome2,xdg}{,-utils}.eclass, though I'm as
39 conflicted as you guys are with regards to the DEPEND/PDEPEND/BDEPEND/RDPEND
40 for it as well.
41 https://archives.gentoo.org/gentoo-dev/message/e0167edbb7b48b03dc90bfbb250ae16d

Replies