1 |
On Tuesday 25 May 2010 23:59:22 Maciej Mrozowski wrote: |
2 |
> On Tuesday 25 of May 2010 20:31:33 Mike Frysinger wrote: |
3 |
> > the library handling is incorrect. i dont think you can pass around |
4 |
> > --enable- shared all the time without having configure generate warnings |
5 |
> > about unknown options. |
6 |
> > |
7 |
> > default to --disable-static when static-libs |
8 |
> > doesnt exist is wrong -- that's the opposite of what you should be doing. |
9 |
> > ignoring the same issue as the share option i mentioned above. |
10 |
> |
11 |
> Right. It its safe to assume that when --disable-static/--enable-static is |
12 |
> available, then --disable-shared/--enable-shared is available as well? |
13 |
|
14 |
i think that's a fair assumption. the vast majority of shared/static |
15 |
enable/disable flags are coming in via libtool and not custom code. the few |
16 |
packages doing custom code can simply write their own econf call. |
17 |
|
18 |
> > the src_test func looks like its copying & pasting stuff from the PM. |
19 |
> > this really should be kept in the PM without duplicating it everywhere. |
20 |
> |
21 |
> Unfortunately src_test needs to be called in build dir (which is unknown to |
22 |
> PM). |
23 |
> Calling default_src_test is the best I could come up with. |
24 |
|
25 |
should be fine |
26 |
|
27 |
> But what's the most important - is there any interest in having such |
28 |
> eclass? I'm only going to add it when it's flexible enough to effectively |
29 |
> phase-out eutils/base/autotools/libtool individual uses for fully |
30 |
> autotools-controlled buildsystems. Otherwise there's no point in yet |
31 |
> another wrapper imho. |
32 |
|
33 |
personally, i probably wouldnt use this. but i dont even like base.eclass. |
34 |
and considering other people seem to like base.eclass, it's reasonable to |
35 |
think people would like this. |
36 |
|
37 |
the out-of-source building will trip up some packages for no reason other than |
38 |
$builddir != $srcdir, but those packages suck and should be fixed in general |
39 |
(unrelated to Gentoo). i imagine some maintainers would be annoyed by having |
40 |
to fix these. |
41 |
-mike |