Gentoo Archives: gentoo-dev

From: Michael Palimaka <kensington@g.o>
To: gentoo-dev@l.g.o, "Michał Górny" <mgorny@g.o>
Cc: kde@g.o, soap@g.o
Subject: [gentoo-dev] Re: [PATCH] cmake-utils.eclass: Override CMAKE_INSTALL_{INFO,MAN}DIR
Date: Fri, 02 Mar 2018 08:53:27
Message-Id: 8eabcd0c-9601-b03a-f93c-7a16e60d2ee3@gentoo.org
In Reply to: [gentoo-dev] [PATCH] cmake-utils.eclass: Override CMAKE_INSTALL_{INFO,MAN}DIR by "Michał Górny"
1 On 03/02/2018 02:40 AM, Michał Górny wrote:
2 > Provide an explicit override for CMAKE_INSTALL_INFODIR
3 > and CMAKE_INSTALL_MANDIR to force Gentoo standards for those locations.
4 > This is needed for Gentoo/FreeBSD where CMake defaults to /usr/info
5 > and /usr/man; while PMS specifies /usr/share/info and /usr/share/man
6 > via econf & do* helpers.
7 > ---
8 > eclass/cmake-utils.eclass | 2 ++
9 > 1 file changed, 2 insertions(+)
10 >
11 > diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
12 > index b9f69a824b14..636927d66491 100644
13 > --- a/eclass/cmake-utils.eclass
14 > +++ b/eclass/cmake-utils.eclass
15 > @@ -602,6 +602,8 @@ cmake-utils_src_configure() {
16 > SET (CMAKE_GENTOO_BUILD ON CACHE BOOL "Indicate Gentoo package build")
17 > SET (LIB_SUFFIX ${libdir/lib} CACHE STRING "library path suffix" FORCE)
18 > SET (CMAKE_INSTALL_LIBDIR ${libdir} CACHE PATH "Output directory for libraries")
19 > + set (CMAKE_INSTALL_INFODIR "${EPREFIX}/usr/share/info" CACHE PATH "")
20 > + set (CMAKE_INSTALL_MANDIR "${EPREFIX}/usr/share/man" CACHE PATH "")
21 > _EOF_
22 > [[ "${NOCOLOR}" = true || "${NOCOLOR}" = yes ]] && echo 'SET (CMAKE_COLOR_MAKEFILE OFF CACHE BOOL "pretty colors during make" FORCE)' >> "${common_config}"
23 >
24 >
25
26 There was some discussion in the past about adding these (and some
27 others), but at that time it was postponed until EAPI 7 due to concerns
28 about breaking existing packages. What do you think about the risk?

Replies