Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: William Hubbs <williamh@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] go-module.eclass: add eapi 8 support
Date: Fri, 02 Jul 2021 06:29:49
Message-Id: u5yxt5iut@gentoo.org
In Reply to: [gentoo-dev] [PATCH] go-module.eclass: add eapi 8 support by William Hubbs
1 >>>>> On Fri, 02 Jul 2021, William Hubbs wrote:
2
3 > # Go packages should not be stripped with strip(1).
4 > -RESTRICT+=" strip"
5 > +if [[ ${EAPI} == 7 ]]; then
6 > + RESTRICT+=" strip"
7 > +else
8 > + RESTRICT=" strip"
9 > +fi
10
11 There was a previous discussion in the QA team that we shouldn't do such
12 changes for PROPERTIES and RESTRICT. While formally correct, they won't
13 improve readability.
14
15 (But if you absolutely want to change it, then the blank in the else
16 assignment is useless, i.e. it should be just RESTRICT="strip".)
17
18 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature