Re: [gentoo-dev] RFC: fortran-2.eclass - Support for bin package system without compiler

[Michał Górny]

Dnia 2013-07-18, o godz. 09:07:22
Justin <jlec@g.o> napisał(a):

> Index: fortran-2.eclass
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/eclass/fortran-2.eclass,v
> retrieving revision 1.18
> diff -u -B -b -u -p -r1.18 fortran-2.eclass
> --- fortran-2.eclass  18 Jul 2013 07:03:33 -0000  1.18
> +++ fortran-2.eclass  18 Jul 2013 07:06:41 -0000
> @@ -203,11 +203,11 @@ _fortran_test_function() {
>    fi
>  }
>
> -# @FUNCTION: fortran-2_pkg_setup
> +# @FUNCTION: _fortran-2_pkg_setup
> +# @INTERNAL
>  # @DESCRIPTION:
> -# Setup functionallity,
> -# checks for a valid fortran compiler and optionally for its openmp
> support.
> -fortran-2_pkg_setup() {
> +# _The_ fortran-2_pkg_setup()

Looks like useful comment ;P.

> +_fortran-2_pkg_setup() {
>    for _f_use in ${FORTRAN_NEEDED}; do
>        case ${_f_use} in
>            always)
> @@ -229,6 +229,29 @@ fortran-2_pkg_setup() {
>    done
>  }
>
> +
> +# @FUNCTION: fortran-2_pkg_setup
> +# @DESCRIPTION:
> +# Setup functionallity,
> +# checks for a valid fortran compiler and optionally for its openmp
> support.
> +fortran-2_pkg_setup() {
> + if [[ ${EAPI:-0} -lt 4 ]]; then

Someone else's going to tell you this, so I'll tell you it first hand:
EAPI is not guaranteed to be a number and you shouldn't be using
numerical comparison against it.

Not that you support any non-numerical EAPI. But then some people who
fork eclasses in overlays will have to patch it more to support their
weird EAPIs. And I'm not pointing my finger at anyone in particular.

> +     eqawarn "The fortran-2.eclass is going to deprecate support for"
> +     eqawarn "EAPI < 4. Please migrate your package to a higher EAPI"
> +     eqawarn "or file a bug at https://bugs.gentoo.org"
> + fi
> +
> + case ${EAPI:-0} in
> +     0|1|2|3)
> +         _fortran-2_pkg_setup ;;
> +     4|5)
> +         if [[ ${MERGE_TYPE} != binary ]]; then
> +             _fortran-2_pkg_setup
> +         fi
> +         ;;
> + esac
> +}
> +
>  case ${EAPI:-0} in
>    0|1|2|3|4|5) EXPORT_FUNCTIONS pkg_setup ;;
>    *) die "EAPI=${EAPI} is not supported" ;;

-- 
Best regards,
Michał Górny