| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
On 08/26/2014 06:23 PM, Anthony G. Basile wrote: |
| 5 |
> On 08/26/14 17:00, Alexander Tsoy wrote: |
| 6 |
>> On Tue Aug 26 22:27:36 2014 Anthony G. Basile <blueness@g.o> |
| 7 |
>> wrote: |
| 8 |
>>> Hi everyone, |
| 9 |
>>> |
| 10 |
>>> I plan to update the pax-utils.eclass because of bug #520198. Can |
| 11 |
>>> people please review that bug and the latest suggestion for the eclass. |
| 12 |
>>> Since I'm inverting some if and for blocks, a diff isn't as useful as |
| 13 |
>>> just looking at the entire class. |
| 14 |
>>> |
| 15 |
>> What if scanelf will fail? Looks like pax-mark() will not report an |
| 16 |
>> error. |
| 17 |
> |
| 18 |
> scanelf doesn't return an error code on failing to pax mark. The paxctl |
| 19 |
> and paxctl-ng do. eg. |
| 20 |
|
| 21 |
Maybe we should read the pax marks back to verify if it works or not |
| 22 |
instead of trusting the return code? We could do it just for scanelf. |
| 23 |
|
| 24 |
- -Zero |
| 25 |
> |
| 26 |
> blueness@yellow /tmp $ rm -f abc |
| 27 |
> blueness@yellow /tmp $ touch abc |
| 28 |
> blueness@yellow /tmp $ scanelf -Xx abc >/dev/null ; echo $? |
| 29 |
> 0 |
| 30 |
> |
| 31 |
> If you want a more sophisticated example, remove the PT_PAX_FLAGS |
| 32 |
> program header from an elf and you get the same results. I don't think |
| 33 |
> its wise to change the behavior of scanelf because its used in portage |
| 34 |
> eg in constructing NEEDED.ELF.2. So its not clear what the unintended |
| 35 |
> consequences would be if we did report an error here. vapier would be |
| 36 |
> able to better address that. I just wrote the eclass following the |
| 37 |
> current behaviour. |
| 38 |
> |
| 39 |
>> |
| 40 |
>> And there are unused variables in pax-mark(): pt_fail* and xt_fail*. |
| 41 |
>> |
| 42 |
> |
| 43 |
> Thanks for catching the cruft. |
| 44 |
> |
| 45 |
> |
| 46 |
|
| 47 |
-----BEGIN PGP SIGNATURE----- |
| 48 |
Version: GnuPG v2 |
| 49 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 50 |
|
| 51 |
iQIcBAEBAgAGBQJT/TKeAAoJEKXdFCfdEflKYB0QAKB/qpHKdqBkoG2lB9dH+1RG |
| 52 |
qIEyqHdf/SFDem31n1WO5On14enSn+cxafltTvg0emL34emg8v1Y0qD3s0CqXt4K |
| 53 |
juX3X8tCnT0CMME/Q4+mgs7aF2+/SLKliUQQ0H842xSSgBGS6uXy6hLa9p0wLOGL |
| 54 |
l9tzSjHGDBuTFdqZEqWiPVKOWw5loKZto0w8z6xHyFicEvNGGIaUZcpvvHs8dM26 |
| 55 |
aDICXrWqbU6dP8rU2AA8CSapEoFjuOQHQWPCzaIGlABSb9X9N/dbeS27bVQdiQm4 |
| 56 |
MBOEJHr9EPYwRRFJ8/XagCRDe3gUgh9p+WROnHZVblMkKRbUJvLqyYSLT220hdRi |
| 57 |
lwFJb8kiXfP446jk821wu2xbf0DYCuqOJFTUL/2lcXUO7atIQJqOlOYlpfL7IGSn |
| 58 |
RYKxDaJSoaxuGkMsqgKcp9gZ8AD/VT6uD1r6iTTkmCAnVQj4UB02XDc+r6+coyUc |
| 59 |
PTjyDiOeQHUhjvoWuJBxAT+TWNZRWXdIkIS1CzGHuCoovGyba+k9JfsOmmFX1HNR |
| 60 |
vFzSnOZ+AwIZSk0Mwbm7yeigrXlnPax3D7cRAACif9+fgkXolYr7NYZWgUuEYmDg |
| 61 |
0BAjAsnK1Hr+UhQ6PmcLy8DH5svV9WaQcTWEGDHkEqavpZG3bqv/XKePXS//9MxK |
| 62 |
rq52G8MW2QlYGVFJd8ZR |
| 63 |
=5Kdh |
| 64 |
-----END PGP SIGNATURE----- |
Archives