Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

[Michał Górny]

On Mon, 2022-07-11 at 09:16 -0400, Mike Gilbert wrote:
> It's common for python_check_deps to call python_has_version, which
> calls ebegin itself.
>
> Signed-off-by: Mike Gilbert <floppym@g.o>
> ---
>  eclass/python-utils-r1.eclass | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
> index a18ca58475f..5c678c524ae 100644
> --- a/eclass/python-utils-r1.eclass
> +++ b/eclass/python-utils-r1.eclass
> @@ -1399,9 +1399,12 @@ _python_run_check_deps() {
>
>  	local PYTHON_USEDEP="python_targets_${impl}(-)"
>  	local PYTHON_SINGLE_USEDEP="python_single_target_${impl}(-)"
> -	ebegin "  python_check_deps"
> -	python_check_deps
> -	eend ${?}
> +	einfo "  python_check_deps"
> +	if python_check_deps; then
> +		einfo "  python_check_deps succeeded"
> +	else
> +		einfo "  python_check_deps failed"
> +	fi
>  }
>
>  # @FUNCTION: python_has_version

WFM.  Please don't push it yet, I'll ask ionen to add it on top of his
patchset for a single merge.

-- 
Best regards,
Michał Górny