Gentoo Archives: gentoo-dev

From: Markus Meier <maekke@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 25/29] distutils-r1.eclass: Ban EXAMPLES in EAPI 6
Date: Sun, 22 Nov 2015 21:15:13
Message-Id: 20151122221437.42b2f85e@gentoo.org
In Reply to: [gentoo-dev] [PATCH 25/29] distutils-r1.eclass: Ban EXAMPLES in EAPI 6 by "Michał Górny"
1 On Sun, 22 Nov 2015 20:51:06 +0100
2 Michał Górny <mgorny@g.o> wrote:
3
4 > ---
5 > eclass/distutils-r1.eclass | 2 ++
6 > 1 file changed, 2 insertions(+)
7 >
8 > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
9 > index e632202..e55e2e4 100644
10 > --- a/eclass/distutils-r1.eclass
11 > +++ b/eclass/distutils-r1.eclass
12 > @@ -583,6 +583,8 @@ distutils-r1_python_install_all() {
13 > einstalldocs
14 >
15 > if declare -p EXAMPLES &>/dev/null; then
16 > + [[ ${EAPI} == [45] ]] && die "EXAMPLES are banned in
17 > EAPI ${EAPI}" +
18
19 I think the logic is the wrong way around and should be "|| die ..."
20
21 > local INSDESTTREE=/usr/share/doc/${PF}/examples
22 > doins -r "${EXAMPLES[@]}"
23 > docompress -x "${INSDESTTREE}"
24
25
26 Regards,
27 Markus

Replies

Subject Author
[gentoo-dev] [PATCH] distutils-r1.eclass: Ban EXAMPLES in EAPI 6 "Michał Górny" <mgorny@g.o>