| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
Ferris McCormick wrote: |
| 5 |
| 2. But to get sparc assembler built correctly, the following patch |
| 6 |
| seems correct: |
| 7 |
|
| 8 |
Looks good to me. |
| 9 |
|
| 10 |
| (Alternative is to create a complete linux-dri-sparc config file; I can |
| 11 |
| do that if you like.) |
| 12 |
|
| 13 |
No need if you don't want to. But it could be useful to get something |
| 14 |
like this so we could send it upstream and they'd have something that |
| 15 |
worked well for everyone else on sparc. |
| 16 |
|
| 17 |
| 3. I changed the double-quoted echo at GLW_LIB ... to single-quoted |
| 18 |
| echo, because I think we need to pass in the $(LIB_DIR), etc. as-is (at |
| 19 |
| least, the ebuild doesn't know what they are and portage complains |
| 20 |
| otherwise). |
| 21 |
|
| 22 |
Could you do double quotes with \$ instead, so it matches the other |
| 23 |
instance? I think that makes it more obvious what's going on to people |
| 24 |
less experienced with bash's quoting. This one just slipped by me, it |
| 25 |
was late. |
| 26 |
|
| 27 |
| I've also attached the little strawman patch to this note, to make it |
| 28 |
| easier to read. I can file a Bug for the change if you like. |
| 29 |
|
| 30 |
Just go ahead and commit it. |
| 31 |
|
| 32 |
Thanks, |
| 33 |
Donnie |
| 34 |
-----BEGIN PGP SIGNATURE----- |
| 35 |
Version: GnuPG v1.4.1 (GNU/Linux) |
| 36 |
|
| 37 |
iD8DBQFC+j8SXVaO67S1rtsRAvlFAKCINple85NJC6AoCAFxpLU+Sq4xugCgxd5f |
| 38 |
o+C3F220/XCTOBJB4+9/Z44= |
| 39 |
=2DlM |
| 40 |
-----END PGP SIGNATURE----- |
| 41 |
-- |
| 42 |
gentoo-dev@g.o mailing list |
Archives