Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o>
Cc: Gentoo Development <gentoo-dev@l.g.o>, qa@g.o
Subject: [gentoo-dev] Re: Patch for python.eclass
Date: Mon, 18 Oct 2010 07:06:30
Message-Id: 201010180306.06911.vapier@gentoo.org
In Reply to: [gentoo-dev] Patch for python.eclass by Arfrever Frehtes Taifersar Arahesis
On October 17, 2010 21:33:20 Arfrever Frehtes Taifersar Arahesis wrote:
> Example usage: > RDEPEND="net-libs/gnutls > $(python_add_abi_dependencies ">=dev-python/PyQt4-4.7.7[svg]") > $(python_add_abi_dependencies -e "2.7 3.[2-9]" dev-python/argparse)" > DEPEND="${RDEPEND} > $(python_add_abi_dependencies dev-python/setuptools) > $(python_add_abi_dependencies -i "3.*" net-zope/zope-fixers) > test? ( $(python_add_abi_dependencies dev-python/py) )"
"dependencies" is overly verbose imo. why not just use "depend" ? plus, "add" usually means the func is the one doing the addition when this is not the case -- the user is the one doing the addition. "python_abi_depend" should be sufficient.
> Subpatch #5 improves some code used in older EAPIs.
does this fix Bug 340395 ? -mike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
[gentoo-dev] Re: Patch for python.eclass Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o>