| 1 |
>>>>> On Wed, 16 Feb 2022, Mart Raudsepp wrote: |
| 2 |
|
| 3 |
> Ühel kenal päeval, K, 16.02.2022 kell 19:39, kirjutas Ulrich Müller: |
| 4 |
>> Function vala_src_prepare did not call eapply_user, so it could not |
| 5 |
>> be |
| 6 |
>> used as a stand-alone phase function but must be called explicitly. |
| 7 |
>> Rename it to vala_setup, which can be called either from pkg_setup or |
| 8 |
>> from src_prepare. |
| 9 |
|
| 10 |
> Just to clarify the reasons to drop the EXPORT - it's really about the |
| 11 |
> fact that you can actually never use it automatically. Absolutely all |
| 12 |
> packages that use vala.eclass need to define their own src_prepare in |
| 13 |
> the ebuild anyways, in order to also call gnome_src_prepare, |
| 14 |
> cmake_src_prepare, or xdg_src_prepare. |
| 15 |
> So the exported phase had no value, as an ebuild author always needs to |
| 16 |
> declare their own, so it's just confusing with the vala_src_prepare |
| 17 |
> function naming from before. |
| 18 |
|
| 19 |
I wonder if we should drop the export retroactively. EAPIs 6 and 7 |
| 20 |
require eapply_user, so if src_prepare is vala_src_prepare then it will |
| 21 |
always result in an error. |
| 22 |
|
| 23 |
Or am I missing something? |
| 24 |
|
| 25 |
Ulrich |
Archives