| 1 |
On 23/09/18 22:27, Kent Fredric wrote: |
| 2 |
> On Sat, 22 Sep 2018 15:36:23 -0500 |
| 3 |
> Matthew Thode <prometheanfire@g.o> wrote: |
| 4 |
>> My hand slipped. What ever happened to assuming the best :( Are you |
| 5 |
>> going to ping the list every time my hand slips up and I mistype |
| 6 |
>> something? Not sure you'll have time for it :P |
| 7 |
> Personally, I would love it if more people tried harder to provide |
| 8 |
> meaningful commit messages. |
| 9 |
> |
| 10 |
> "bup" vs "bump" isn't really achieving much, just one of the two are |
| 11 |
> substantially more egregious. |
| 12 |
> |
| 13 |
> Perhaps, if the commit messages were crafted with clarity as their |
| 14 |
> intent, the consequence of accidental typos would be much more |
| 15 |
> inconsequential. |
| 16 |
> |
| 17 |
> ( I seriously think we could do with a *little* more chiding here than |
| 18 |
> we generally see, but like, I'm typically just biting my tongue every |
| 19 |
> time somebody doesn't invest any more effort than to write the word |
| 20 |
> "bump" in their text editor when committing with repoman, cos I really |
| 21 |
> don't want to be a dick about it. There's room for more than 4 |
| 22 |
> characters and a space in the subject, and infinitely more space in the |
| 23 |
> body, why do we have to choose the least clear of all options? ) |
| 24 |
> |
| 25 |
> Occasional accidents are still gonna happen, but it would be nice if we |
| 26 |
> didn't define accidents and siblings of accidents as the status quo. |
| 27 |
> |
| 28 |
I think Kent has pretty much the point here .. we try to stipulate that |
| 29 |
the commit message describes what the update is, and is clear for *all* |
| 30 |
users of the repository, and not just the relevant maintainer. There is |
| 31 |
also a cronic double-standard for existing or long-standing devs, and |
| 32 |
newer devs, recruits and proxy-maintainers (who get a double-scrutiny |
| 33 |
typically) - and I could easily see how this breeds resentment... |
| 34 |
|
| 35 |
Perhaps it would be simple enough to add a check to repoman for commit |
| 36 |
messages less than 10 characters, and with at least one *additional* |
| 37 |
space, mandating two words in the commit message. It seems draconian, |
| 38 |
but if developers continue to be lazy, what choice does one have?! |
Archives