Re: [gentoo-dev] [PATCH 1/2] bzr.eclass: Reinstate eclass

[Michał Górny]

On Mon, 2021-09-27 at 19:25 +0200, Ulrich Mueller wrote:
> > > > > > On Sat, 25 Sep 2021, Michał Górny wrote:
>
> > > +EBZR="bzr.eclass"
>
> > Why do we need this?  It seems as if someone is reinventing
> > ${ECLASS}.
>
> Replaced by ${ECLASS}.
>
> > > +# @ECLASS-VARIABLE: EBZR_STORE_DIR
>
> > @USER_VARIABLE?
>
> Added.
>
> > > +# @DESCRIPTION:
> > > +# The directory to store all fetched Bazaar live sources.
> > > +: ${EBZR_STORE_DIR:=${PORTAGE_ACTUAL_DISTDIR:-${DISTDIR}}/bzr-
> > > src}
> > > +
> > > +# @ECLASS-VARIABLE: EBZR_UNPACK_DIR
> > > +# @DESCRIPTION:
> > > +# The working directory where the sources are copied to.
> > > +: ${EBZR_UNPACK_DIR:=${WORKDIR}/${P}}
> > > +
> > > +# @ECLASS-VARIABLE: EBZR_INIT_REPO_CMD
> > > +# @DESCRIPTION:
> > > +# The Bazaar command to initialise a shared repository.
> > > +: ${EBZR_INIT_REPO_CMD:="bzr init-repository --no-trees"}
> > > +
> > > +# @ECLASS-VARIABLE: EBZR_FETCH_CMD
> > > +# @DESCRIPTION:
> > > +# The Bazaar command to fetch the sources.
> > > +: ${EBZR_FETCH_CMD:="bzr branch --no-tree"}
> > > +
> > > +# @ECLASS-VARIABLE: EBZR_UPDATE_CMD
> > > +# @DESCRIPTION:
> > > +# The Bazaar command to update the sources.
> > > +: ${EBZR_UPDATE_CMD:="bzr pull --overwrite-tags"}
> > > +
> > > +# @ECLASS-VARIABLE: EBZR_EXPORT_CMD
> > > +# @DESCRIPTION:
> > > +# The Bazaar command to export a branch.
> > > +: ${EBZR_EXPORT_CMD:="bzr export"}
> > > +
> > > +# @ECLASS-VARIABLE: EBZR_CHECKOUT_CMD
> > > +# @DESCRIPTION:
> > > +# The Bazaar command to checkout a branch.
> > > +: ${EBZR_CHECKOUT_CMD:="bzr checkout --lightweight -q"}
> > > +
> > > +# @ECLASS-VARIABLE: EBZR_REVNO_CMD
> > > +# @DESCRIPTION:
> > > +# The Bazaar command to list a revision number of the branch.
> > > +: ${EBZR_REVNO_CMD:="bzr revno"}
>
> > Are you sure that having these overrides is a good idea?
>
> Yes. Ebuilds had used them in the past.
>
> > Your followup patch pretty much proves that every ebuild redefining
> > them would get broken by switch to breezy.
>
> The only one where syntax has changed is EBZR_INIT_REPO_CMD (which has
> init-shared-repository instead of init-repository).

You seem to be missing the fact that all of them hardcode "bzr".


-- 
Best regards,
Michał Górny