| 1 |
On Thu, Aug 18, 2011 at 8:27 AM, Fabian Groffen <grobian@g.o> wrote: |
| 2 |
> On 18-08-2011 16:57:59 +0200, Michał Górny wrote: |
| 3 |
>> > # @ECLASS-VARIABLE: LC_PCAT |
| 4 |
>> > # @DESCRIPTION: |
| 5 |
>> > # Set this to the category of the plugin, if any. |
| 6 |
>> > : ${LC_PCAT:=} |
| 7 |
>> |
| 8 |
>> Please use verbose variable names, and prefix them with eclass |
| 9 |
>> filename; e.g. LEECHCRAFT_PLUGIN_CATEGORY. |
| 10 |
> |
| 11 |
> Really? The python eclass is full of such awkward overly verbose names. |
| 12 |
> One can also exaggerate... |
| 13 |
|
| 14 |
python.eclass, perhaps not the best style to use as a defense ;) |
| 15 |
|
| 16 |
-A |
| 17 |
|
| 18 |
> |
| 19 |
>> > if [ "${LC_PCAT+x}" != "x" ]; then |
| 20 |
>> > CMAKE_USE_DIR="${S}/src/plugins/${LC_PCAT}/${PN#leechcraft-}" |
| 21 |
>> > else |
| 22 |
>> > if [[ ${PN} != "leechcraft-core" ]]; then |
| 23 |
>> > CMAKE_USE_DIR="${S}/src/plugins/${PN#leechcraft-}" |
| 24 |
>> > else |
| 25 |
>> > CMAKE_USE_DIR="${S}/src" |
| 26 |
>> > fi |
| 27 |
>> > fi |
| 28 |
>> |
| 29 |
>> if-elif-else-fi. |
| 30 |
> |
| 31 |
> This sounds like a kind of bogus suggestion to me. Mixing use of [ and |
| 32 |
> [[, on the other hand, is more what deserves attention here. |
| 33 |
> |
| 34 |
> |
| 35 |
> |
| 36 |
> -- |
| 37 |
> Fabian Groffen |
| 38 |
> Gentoo on a different level |
| 39 |
> |
| 40 |
> |
Archives