| 1 |
On 2/28/06, Patrick Lauer <patrick@g.o> wrote: |
| 2 |
> On Tue, 2006-02-28 at 17:38 +0000, Ciaran McCreesh wrote: |
| 3 |
> > Sheesh, you'll probably claim that this isn't broken next too: |
| 4 |
> > |
| 5 |
> > if [ "${IS_UPGRADE}" = "1" ] ; then |
| 6 |
> > einfo "Removing old version ${REMOVE_PKG}" |
| 7 |
> > |
| 8 |
> > emerge -C "${REMOVE_PKG}" |
| 9 |
> > fi |
| 10 |
> Ciaran, |
| 11 |
> (and this is valid for all emails to technical lists,) |
| 12 |
> please save us some time and many emails by stating what is wrong when |
| 13 |
> you show a QA violation. |
| 14 |
> Many among us don't think in assembler and don't know enough about the |
| 15 |
> code to decide if/why something is wrong. This in turn causes someone |
| 16 |
> (like me) to send an email asking what is wrong, causing another reply |
| 17 |
> by you etc. etc. |
| 18 |
> |
| 19 |
> It's a bit like me stating: |
| 20 |
> "The bug is in line 14: |
| 21 |
> i+=2 |
| 22 |
> " |
| 23 |
> If you don't know the code you won't understand why. |
| 24 |
> |
| 25 |
> Now if I said "line 14 increments by two, but then you won't ever get |
| 26 |
> out of the loop since the exit condition won't be met" everyone could |
| 27 |
> understand it and evaluate my statement. |
| 28 |
> |
| 29 |
> If you show a wrong code snippet please explain _why_ it is wrong in the |
| 30 |
> same email. |
| 31 |
|
| 32 |
I believe the bug is calling emerge from within the eclass. |
| 33 |
|
| 34 |
|
| 35 |
> |
| 36 |
> Thanks, |
| 37 |
> |
| 38 |
> Patrick |
| 39 |
> |
| 40 |
> -- |
| 41 |
> Stand still, and let the rest of the universe move |
| 42 |
> |
| 43 |
> |
| 44 |
> -----BEGIN PGP SIGNATURE----- |
| 45 |
> Version: GnuPG v1.4.2.1-ecc0.1.6 (GNU/Linux) |
| 46 |
> |
| 47 |
> iD8DBQBEBI+UqER3hOUoZM4RAjzxAJ9tvaSOY3625NaptPTj/yLxXrIXJACeITwy |
| 48 |
> 43JQjZpI+HEckc6Mla3f9l0= |
| 49 |
> =so5q |
| 50 |
> -----END PGP SIGNATURE----- |
| 51 |
> |
| 52 |
> |
| 53 |
> |
| 54 |
|
| 55 |
-- |
| 56 |
gentoo-dev@g.o mailing list |
Archives