Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH 1/3] eutils.eclass: prune_libtool_files, punt pointless Prefix logic
Date: Sun, 12 Mar 2017 11:01:23
Message-Id: 20170312110009.3109-2-mgorny@gentoo.org
In Reply to: [gentoo-dev] [PATCH v2] ltprune.eclass by "Michał Górny"
1 Remove the unnecessary Prefix logic from prune_libtool_files(). There is
2 no functional difference between starting a find in ${D} and ${ED}
3 (since ${D} is not supposed to contain other directories on a Prefix
4 system), and using the latter implies unnecessary hackery for older
5 EAPIs.
6 ---
7 eclass/eutils.eclass | 3 +--
8 1 file changed, 1 insertion(+), 2 deletions(-)
9
10 diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
11 index e036001dc5e1..ab226b236a37 100644
12 --- a/eclass/eutils.eclass
13 +++ b/eclass/eutils.eclass
14 @@ -898,7 +898,6 @@ prune_libtool_files() {
15 debug-print-function ${FUNCNAME} "$@"
16
17 local removing_all removing_modules opt
18 - _eutils_eprefix_init
19 for opt; do
20 case "${opt}" in
21 --all)
22 @@ -1008,7 +1007,7 @@ prune_libtool_files() {
23 einfo "Removing unnecessary ${f#${D%/}} (${reason})"
24 queue+=( "${f}" )
25 fi
26 - done < <(find "${ED}" -xtype f -name '*.la' -print0)
27 + done < <(find "${D}" -xtype f -name '*.la' -print0)
28
29 if [[ ${queue[@]} ]]; then
30 rm -f "${queue[@]}"
31 --
32 2.12.0