Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH] perl-functions.eclass: Replace unnecessary eval with ${!var}
Date: Thu, 23 Feb 2017 17:02:24
Message-Id: 20170223170210.10046-1-mgorny@gentoo.org
1 ---
2 eclass/perl-functions.eclass | 2 +-
3 1 file changed, 1 insertion(+), 1 deletion(-)
4
5 diff --git a/eclass/perl-functions.eclass b/eclass/perl-functions.eclass
6 index 1542b98cd45f..85907354a309 100644
7 --- a/eclass/perl-functions.eclass
8 +++ b/eclass/perl-functions.eclass
9 @@ -276,7 +276,7 @@ perl_check_env() {
10 errored=1
11
12 # Read ENV Value
13 - eval "value=\$$i";
14 + value=${!i};
15
16 # Print ENV name/value pair
17 if [ -n "${I_KNOW_WHAT_I_AM_DOING}" ]; then
18 --
19 2.11.1

Replies