Gentoo Archives: gentoo-dev

From: "Paweł Hajdan
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] suspicious code in gnustep eclasses
Date: Tue, 29 May 2012 08:07:33
Message-Id: 4FC48365.3080506@gentoo.org
In Reply to: Re: [gentoo-dev] suspicious code in gnustep eclasses by Fabian Groffen
1 On 3/31/12 8:45 AM, Fabian Groffen wrote:
2 > On 30-03-2012 13:00:33 +0200, "Paweł Hajdan, Jr." wrote:
3 >> This is from gnustep-base.eclass:
4 >>
5 >>> egnustep_doc() {
6 >>> if [[ -d ./Documentation ]] ; then
7 >>> # Check documentation presence
8 >>> cd "${S}"/Documentation
9 >>> if [[ -f ./[mM]akefile || -f ./GNUmakefile ]] ; then
10 >>> emake "${GS_ENV[@]}" all || die "doc make failed"
11 >>> emake "${GS_ENV[@]}" install || die "doc install failed"
12 >>> fi
13 >>> cd ..
14 >>> fi
15 >>> }
16 >>
17 >> Shouldn't those cd calls above rather be pushd/popd? It seems the above
18 >> assumes that CWD is "${S}" when egnustep_doc is executed, which is
19 >> probably true, but pushd/popd seems just safer.
20 >
21 > Go ahead.
22
23 I've checked in this and all other changes to CVS, after testing gnustep
24 packages locally.
25
26 Paweł

Attachments

File name MIME type
signature.asc application/pgp-signature