Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: aballier@g.o
Subject: Re: [gentoo-dev] [PATCH] autotools-multilib: wrapper eclass for multilib builds.
Date: Sun, 23 Sep 2012 16:32:46
Message-Id: 20120923183125.7c801781@pomiocik.lan
In Reply to: Re: [gentoo-dev] [PATCH] autotools-multilib: wrapper eclass for multilib builds. by Alexis Ballier
1 On Sun, 23 Sep 2012 12:47:44 -0300
2 Alexis Ballier <aballier@g.o> wrote:
3
4 > On Sun, 23 Sep 2012 09:21:20 +0200
5 > Michał Górny <mgorny@g.o> wrote:
6 >
7 > > On Sat, 22 Sep 2012 21:46:02 -0300
8 > > Alexis Ballier <aballier@g.o> wrote:
9 > >
10 > > > On Sat, 22 Sep 2012 23:24:46 +0200
11 > > > Michał Górny <mgorny@g.o> wrote:
12 > > >
13 > > > > It is a simple eclass using autotools out-of-source builds to
14 > > > > build packages for multiple ABIs when multilib is supported.
15 > > > >
16 > > >
17 > > > to some extent, can't you do the same by unpacking twice to
18 > > > different $S and calling src_prepare/compile/install instead of
19 > > > their autotools-utils counterpart with tweaked $S so that it works
20 > > > with almost every ebuild ?
21 > >
22 > > That would make this solution inefficient.
23 >
24 > Why ?
25
26 Because it introduces unnecessarily copying files around.
27
28 > > The good solutions should
29 > > not be made ugly to support corner cases.
30 >
31 > You are tying support to one specific build system, and one specific
32 > usage within ebuilds. That is what I would call a corner case :)
33 > Ebuilds already define a standardized way of building packages, why not
34 > use this directly ?
35 > I'm not saying your proposal is useless, it is indeed more efficient
36 > than a generic one, but rather that a generic solution is neither much
37 > more complicated nor that inefficient in comparison.
38
39 It's a common case.
40
41 A generic solution is more complicated if it is supposed to use phase
42 functions exported by some eclass. By using a generic solution you lose
43 the ability to 'automagically' use last exported function.
44
45 Some time ago I suggested replacing 'default' with something like
46 'next' (which would allow one exported phase function to call the one
47 from next inherited eclass) but I don't think I got any response.
48
49 --
50 Best regards,
51 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies