Gentoo Archives: gentoo-dev

From: Donnie Berkholz <dberkholz@g.o>
To: gentoo-dev@l.g.o
Cc: mrness@g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in www-apps/dspam-web: dspam-web-3.8.0.ebuild ChangeLog
Date: Tue, 25 Sep 2007 00:51:15
Message-Id: 20070925003919.GW22279@supernova
1 On 20:40 Mon 24 Sep , Alin Nastac (mrness) wrote:
2 > mrness 07/09/24 20:40:54
3 >
4 > Modified: dspam-web-3.8.0.ebuild ChangeLog
5 > Log:
6 > Die in pkg_setup if dev-perl/GD has been installed without png USE flag (#193662). Update patches tarball to match the one used in latest mail-filter/dspam version.
7 > (Portage version: 2.1.3.9)
8
9 > - mirror://gentoo/dspam-${PV}-patches-20070624.tar.gz"
10 > + mirror://gentoo/dspam-${PV}-patches-20070909.tar.gz"
11
12 It might increase readability and decrease maintenance to pull this date
13 out into a separate variable.
14
15 > + local use_errors=0
16 > + if built_with_use "mail-filter/dspam" user-homedirs; then
17 > + echo
18 > + eerror "The DSPAM web interface requires that mail-filter/dspam be installed without user-homedirs USE flag."
19 > eerror "Please disable this flag and re-emerge dspam."
20 > - die "Incompatible mail-filter/dspam installation"
21 > + use_errors=$[${use_errors} + 1]
22 > + fi
23 > + if ! built_with_use "dev-perl/GD" png; then
24 > + echo
25 > + eerror "The DSPAM web interface requires that dev-perl/GD be installed with png USE flag."
26 > + eerror "Please enable this flag and re-emerge GD."
27 > + use_errors=$[${use_errors} + 1]
28 > fi
29 > + [ ${use_errors} -gt 0 ] && die "Dependency installed with incompatible USE flags"
30
31 You could use C-style syntax here:
32
33 (( use_errors++ ))
34
35 I find it a bit more readable.
36
37 Thanks,
38 Donnie
39 --
40 gentoo-dev@g.o mailing list

Replies