Gentoo Archives: gentoo-dev

From: Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o>
To: Gentoo Development <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] Locale check in python_pkg_setup()
Date: Sat, 31 Jul 2010 14:45:34
Message-Id: 201007311645.49028.Arfrever@gentoo.org
In Reply to: Re: [gentoo-dev] Locale check in python_pkg_setup() by Brian Harring
1 2010-07-30 04:36:22 Brian Harring napisaƂ(a):
2 > On Fri, Jul 30, 2010 at 01:16:42AM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
3 > > --- python.eclass
4 > > +++ python.eclass
5 > > @@ -355,6 +355,8 @@
6 > > # Check if phase is pkg_setup().
7 > > [[ "${EBUILD_PHASE}" != "setup" ]] && die "${FUNCNAME}() can be used only in pkg_setup() phase"
8 > >
9 > > + local locale
10 > > +
11 > > if [[ "$#" -ne 0 ]]; then
12 > > die "${FUNCNAME}() does not accept arguments"
13 > > fi
14 > > @@ -407,6 +409,16 @@
15 > > unset -f python_pkg_setup_check_USE_flags
16 > > fi
17 > >
18 > > + locale="$(python -c 'import os; print(os.environ.get("LC_ALL", os.environ.get("LC_CTYPE", os.environ.get("LANG", "POSIX"))))')"
19 >
20 > You're using python to get the exported env. Don't. Use bash (you're
21 > invoking python from freaking bash after all)...
22
23 Given variable can be set, but not exported.
24
25 > bug 328047 is induced by a patch we add (it's not in upstream python).
26
27 This patch comes from upstream.
28
29 --
30 Arfrever Frehtes Taifersar Arahesis

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] Locale check in python_pkg_setup() Alec Warner <antarus@g.o>