Gentoo Archives: gentoo-dev

From: Alexis Ballier <aballier@g.o>
To: gentoo-dev@l.g.o
Cc: yngwin@g.o
Subject: [OT/NIT] Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in profiles: ChangeLog package.mask
Date: Sun, 21 Apr 2013 15:06:04
Message-Id: 20130421170549.41cfea49@portable
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in profiles: ChangeLog package.mask by Ben de Groot
1 On Sun, 21 Apr 2013 20:53:28 +0800
2 Ben de Groot <yngwin@g.o> wrote:
3 > >
4 > > PS: btw, some hunks are weird in your commit, a locale issue ?
5 > >
6 >
7 > No, just a line in my vimrc that removes trailing whitespace.
8 >
9
10 You should probably disable it or remove trailing whitespaces in a
11 separate commit though. Having functional changes mixed with
12 whitespace/cosmetics in a single commit makes it hard to read
13 and understand.
14
15 [This is really a nitpick, no need to have a debate, it's only a
16 suggestion ;)]
17
18 Alexis.

Replies