Gentoo Archives: gentoo-dev

From: David Michael <fedora.dm0@×××××.com>
To: Ulrich Mueller <ulm@g.o>
Cc: gentoo-dev@l.g.o, Mike Gilbert <floppym@g.o>, "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-dev] [PATCH 1/2] ninja-utils.eclass: EAPI 8 support
Date: Thu, 24 Jun 2021 17:07:26
Message-Id: CAEvUa7kpmfisX-bFzzSc2bWrp9kTgUma=EwtxSKuhYzgPXnamg@mail.gmail.com
In Reply to: Re: [gentoo-dev] [PATCH 1/2] ninja-utils.eclass: EAPI 8 support by Ulrich Mueller
1 On Thu, Jun 24, 2021 at 12:51 PM Ulrich Mueller <ulm@g.o> wrote:
2 > >>>>> On Thu, 24 Jun 2021, David Michael wrote:
3 > > --- a/eclass/ninja-utils.eclass
4 > > +++ b/eclass/ninja-utils.eclass
5 > > @@ -1,4 +1,4 @@
6 > > -# Copyright 1999-2018 Gentoo Foundation
7 > > +# Copyright 1999-2021 Gentoo Foundation
8 >
9 > Please update to "Gentoo Authors".
10 >
11 > > # Distributed under the terms of the GNU General Public License v2
12 > >
13 > > # @ECLASS: ninja-utils.eclass
14 > > @@ -8,7 +8,7 @@
15 > > # @AUTHOR:
16 > > # Michał Górny <mgorny@g.o>
17 > > # Mike Gilbert <floppym@g.o>
18 > > -# @SUPPORTED_EAPIS: 2 4 5 6 7
19 > > +# @SUPPORTED_EAPIS: 5 6 7 8
20 > > # @BLURB: common bits to run dev-util/ninja builder
21 > > # @DESCRIPTION:
22 > > # This eclass provides a single function -- eninja -- that can be used
23 > > @@ -21,10 +21,8 @@
24 > > if [[ -z ${_NINJA_UTILS_ECLASS} ]]; then
25 > >
26 > > case ${EAPI:-0} in
27 >
28 > This could be simplified to "case ${EAPI} in".
29
30 Okay, I've updated https://github.com/gentoo/gentoo/pull/21409 and
31 also moved the EAPI check outside the inherit guard, since that's what
32 other eclasses seem to do.
33
34 Thanks.
35
36 David