Re: [gentoo-dev] .gitignore

[Mike Gilbert]

On Wed, Aug 12, 2015 at 6:22 PM, Alan McKinnon <alan.mckinnon@×××××.com> wrote:
> On 13/08/2015 00:21, James Le Cuirot wrote:
>> On Thu, 13 Aug 2015 00:11:45 +0200
>> Alan McKinnon <alan.mckinnon@×××××.com> wrote:
>>
>>> On 12/08/2015 23:29, James Le Cuirot wrote:
>>>> Mike Frysinger <vapier <at> gentoo.org> writes:
>>>>>
>>>>> On 10 Aug 2015 09:17, Michał Górny wrote:
>>>>>> Dnia 2015-08-10, o godz. 02:42:21 Mike Frysinger napisał(a):
>>>>>>> On 10 Aug 2015 08:28, Justin (jlec) wrote:
>>>>>>>> I like to propose to add the md5-cache into it. Which other
>>>>>>>> files are of interest?
>>>>>>>
>>>>>>> /distfiles/
>>>>>>> /local/
>>>>>>> /packages/
>>>>>>
>>>>>> Those directories should not be ignored. Those should not exist
>>>>>> for a long time.
>>>>>
>>>>> there's no reason people can't use these on their own system.
>>>>> there's no reason they should be added to the git repo which means,
>>>>> if a user opted to utilize them, they should be ignored.
>>>>
>>>> I agree and I'm not sure what mgorny is basing his statement on
>>>> anyway. Apart from /local/, which I forget the purpose of, the
>>>> default locations for DISTDIR and PKGDIR still seem to
>>>> be /usr/portage/distfiles and /usr/portage/packages. I must admit
>>>> that I'm struggling to find the logic for this in Portage but those
>>>> are the defaults nonetheless. So why would they not exist? I'm
>>>> certainly using them here and I would like to see them
>>>> in .gitignore.
>>>
>>> /usr/portage/local was the original location for the user's own
>>> personal ebuild space - an "overlay" if you will.
>>> /usr/portage/distfiles and /usr/portage/packages are there because
>>> that's where ports has put them for decades, and no-one has gotten
>>> around to changing it in portage yet. FreeBSD defines the use of /usr
>>> very differently to what Linux users are used to.
>>>
>>> Those dirs really should be in /var/portage, and the user's overlay
>>> has no business being under main tree itself
>>
>> I didn't say they were the most appropriate locations and I agree
>> that /var/portage is best but that doesn't change the fact that they
>> are still the defaults. :)
>>
>
> Indeed. And it's equally true they should be git ignored.

I went ahead and added them.

commit 0f87115a27f70502eed95cd27b71449eb66dc7b1
Author: Mike Gilbert <floppym@g.o>
Date:   Wed Aug 12 21:27:59 2015 -0400

    Add some additional legacy directories to .gitignore

diff --git a/.gitignore b/.gitignore
index 87c1cce..1f8c184 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,5 @@
 /.ebuild.x
-profiles/use.local.desc
+/distfiles/
+/local/
+/packages/
+/profiles/use.local.desc