Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: Austin English <wizardedit@g.o>
Cc: toolchain@g.o, gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 2/2] eclass/toolchain-funcs: add clang version functions
Date: Fri, 01 Jul 2016 20:02:30
Message-Id: 20160701220211.02bc2b72.mgorny@gentoo.org
In Reply to: [gentoo-dev] [PATCH 2/2] eclass/toolchain-funcs: add clang version functions by Austin English
1 On Mon, 27 Jun 2016 17:04:41 -0500
2 Austin English <wizardedit@g.o> wrote:
3
4 > From ec0be3d1a808ea0c5bdd081a4bb935f86bf78d44 Mon Sep 17 00:00:00 2001
5 > From: Austin English <wizardedit@g.o>
6 > Date: Mon, 27 Jun 2016 16:58:07 -0500
7 > Subject: [PATCH 2/2] eclass/toolchain-funcs: add clang version functions
8
9 Why do you even ask for review if you can't wait till the weekend
10 before committing?
11
12 I've already told you twice that I'm opposed to adding version querying
13 functions for clang, especially for the use case you proposed. You
14 should check for features, and not keep a huge list of supported gcc,
15 clang, pathcc, icc... versions. With every random compiler pretending
16 to be a random version of every other compiler.
17
18 --
19 Best regards,
20 Michał Górny
21 <http://dev.gentoo.org/~mgorny/>

Replies