| 1 |
Peter Stuge <peter@×××××.se> writes: |
| 2 |
|
| 3 |
>> + pushd "${EPREFIX}$(get_erl_libs)" >/dev/null |
| 4 |
>> + for p in ${pn} ${pn}-*; do |
| 5 |
>> + if [[ -d ${p} ]]; then |
| 6 |
>> + echo "${p#${pn}-}" |
| 7 |
>> + return 0 |
| 8 |
> |
| 9 |
> No popd on success? |
| 10 |
|
| 11 |
Thanks for catching this up! Fixed. |
| 12 |
|
| 13 |
>> + local tmpf="$(emktemp)" |
| 14 |
>> + |
| 15 |
>> + cat "${f}" >"${tmpf}" || return 1 |
| 16 |
>> + awk "$@" "${tmpf}" >"${f}" |
| 17 |
>> +} |
| 18 |
> |
| 19 |
> Wouldn't it be nicer to cut cat, awk > $tmpf && mv $tmpf $f ? |
| 20 |
|
| 21 |
No. Please see separate review of eawk where it is explained. |
| 22 |
|
| 23 |
Thanks, |
| 24 |
-- Amadeusz Żołnowski |
Archives