Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: ruby@g.o, Naohiro Aota <naota@g.o>
Subject: Re: [gentoo-dev] [PATCH v2 05/10] ruby-ng-gnome2.eclass: Use [[ instead of [
Date: Mon, 04 May 2020 05:05:29
Message-Id: 1574028f11dfd4adac5f083fa83e5caf2b8ebba2.camel@gentoo.org
In Reply to: [gentoo-dev] [PATCH v2 05/10] ruby-ng-gnome2.eclass: Use [[ instead of [ by Naohiro Aota
1 On Mon, 2020-05-04 at 11:22 +0900, Naohiro Aota wrote:
2 > Signed-off-by: Naohiro Aota <naota@g.o>
3 > ---
4 > eclass/ruby-ng-gnome2.eclass | 2 +-
5 > 1 file changed, 1 insertion(+), 1 deletion(-)
6 >
7 > diff --git a/eclass/ruby-ng-gnome2.eclass b/eclass/ruby-ng-gnome2.eclass
8 > index 4f3f6011501b..ac112e006205 100644
9 > --- a/eclass/ruby-ng-gnome2.eclass
10 > +++ b/eclass/ruby-ng-gnome2.eclass
11 > @@ -77,7 +77,7 @@ each_ruby_install() {
12 > # Install the files common to all ruby targets.
13 > all_ruby_install() {
14 > for doc in ../AUTHORS ../NEWS ChangeLog README; do
15 > - [ -s "$doc" ] && dodoc $doc
16 > + [[ -s "$doc" ]] && dodoc $doc
17
18 Use ${doc} while at it, please. Also quoting is no longer necessary
19 in [[ ]].
20
21 > done
22 > if [[ -d sample ]]; then
23 > insinto /usr/share/doc/${PF}
24
25 --
26 Best regards,
27 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature