1 |
On 2018-08-21 18:23, Michał Górny wrote: |
2 |
>> Wait, are you saying that I can set USE=-test while FEATURES=test is |
3 |
>> enabled? Is that a valid combination? |
4 |
> |
5 |
> Yes. |
6 |
|
7 |
The only thing I still don't understand yet: Do we support things like that? |
8 |
|
9 |
I.e. should we add things like |
10 |
|
11 |
> if has test ${FEATURES} && ! use test ; then |
12 |
> eerror "FEATURES=test requires USE=test." |
13 |
> die "FEATURES=test set but not USE=test" |
14 |
> fi |
15 |
|
16 |
if a package's src_test phase requires some conditional stuff or is it |
17 |
something like "user shoot himself into the foot" so we do *not* care |
18 |
because we still assume "if FEATURES=test, USE=test is *normally* set"? |
19 |
|
20 |
Asking from user experience point of view: Imagine a user tries to |
21 |
emerge a package which will compile multiple hours and src_test just |
22 |
fails because some conditional stuff didn't run due to USE=-test |
23 |
accidentally set by the user (in the past or was forgotten). |
24 |
|
25 |
The code above in an early phase like pkg_setup would prevent such a bad |
26 |
user experience, not? |
27 |
|
28 |
|
29 |
-- |
30 |
Regards, |
31 |
Thomas Deutschmann / Gentoo Linux Developer |
32 |
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5 |