| 1 |
On Sun, Sep 30, 2018 at 6:51 PM Michael Orlitzky <mjo@g.o> wrote: |
| 2 |
> |
| 3 |
> The "modules" USE flag was originally enabled by default in the base |
| 4 |
> profile so that any ebuild inheriting linux-mod.eclass would have its |
| 5 |
> kernel modules built by default. However, the name of that USE flag is |
| 6 |
> now controlled by the MODULES_OPTIONAL_USE variable, set in the ebuild |
| 7 |
> itself. The best place for the USE flag default is therefore in IUSE |
| 8 |
> (in the ebuild), because only the ebuild knows the correct flag name. |
| 9 |
> |
| 10 |
> There are at least two packages, media-gfx/graphicsmagick and |
| 11 |
> net-im/mcabber, that assign a different meaning to the "modules" flag, |
| 12 |
> further suggesting that a global default is too blunt an approach. |
| 13 |
> |
| 14 |
> This commit drops the flag from base/make.defaults, and also from |
| 15 |
> default/linux/make.defaults where a redundant entry was present. |
| 16 |
> Thereafter, the override in features/hardened/make.defaults is |
| 17 |
> unnecessary, so it has been dropped as well. |
| 18 |
> |
| 19 |
> Closes: https://bugs.gentoo.org/635720 |
| 20 |
> Signed-off-by: Michael Orlitzky <mjo@g.o> |
| 21 |
|
| 22 |
Looks good to me. |
Archives