Re: [gentoo-dev] CONFIG_PROTECT and ROOT!='/'

[Georgi Georgiev]

maillog: 14/03/2005-22:24:24(-0600): Brian Jackson types
> On Mon, 2005-03-14 at 13:21 -0800, Donnie Berkholz wrote:
> > Vitaly Ivanov wrote:
> > > I found the comments of Nicholas Jones in bug
> > > http://bugs.gentoo.org/show_bug.cgi?id=52415
> > >>> Portage makes the assumption that if you're installing
> > >>> into a new root, then you're building a system and
> > >>> shouldn't bother with config protection. It's not
> > >>> documented either way, so it's undefined behavior.
> >
> > I disagree with that logic, because people may be maintaining systems in
> > a ROOT with modified config files. Updating those systems trashes the
> > files. Thank you for pointing out this behavior now, because it walks
> > all over plans I have for a diskless cluster.
>
> I mentioned this to the portage guys the other day. Either they didn't
> care, or they didn't hear me. Either way, probably need to file a bug
> about it (or stir up that other one).

Alright! The bug is getting attention, and it even hasn't been a year!

I posted a patch at http://bugs.gentoo.org/show_bug.cgi?id=52415 that
addresses the issue.  You can directly do

wget http://bugs.gentoo.org/attachment.cgi?id=53496 -O - | patch -p0

which will in turn screw your portage.py, but hopefully for the best.

As I see that there are more people who are interested in the bug, I am
expecting at least some to trust me enough as to try out the patch and
in turn make some noise (yeah, noise is what we need) when it makes them
happy.

The other problem that bothers me (that is: reading configuration
files from $ROOT) seems to be worked on. At least, there are
comments like:

	# XXX: This should depend on ROOT?
	if os.path.exists("/"+CUSTOM_PROFILE_PATH):
		self.user_profile_dir = os.path.normpath("/"+"///"+CUSTOM_PROFILE_PATH)
		self.profiles.append(self.user_profile_dir[:])

...

	# XXX: Should depend on root?
		self.mygcfg=getconfig("/"+MAKE_CONF_FILE,allow_sourcing=True)
		if self.mygcfg == None:
			self.mygcfg = {}


Which I guess means that it will sooner or later make it to the next
level in some form.

chutz out

-- 
*)   Georgi Georgiev   *) Live fast, die young, and leave a flat       *)
(*    chutz@×××.net    (* patch of fur on the highway! -- The          (*
*)  [phone]   *) Squirrels' Motto (The "Hell's Angels of      *)
(* ------------------- (* Nature")                                     (*