From: | Nirbheek Chauhan <nirbheek@g.o> | ||
---|---|---|---|
To: | gentoo-dev@l.g.o | ||
Cc: | djc@g.o | ||
Subject: | Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild | ||
Date: | Fri, 01 Oct 2010 15:18:08 | ||
Message-Id: | AANLkTinHDE47OULymozGiBM5virdxKTdFXTg6oVdAGSs@mail.gmail.com | ||
In Reply to: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild by Peter Volkov |
1 | On Fri, Oct 1, 2010 at 6:37 PM, Peter Volkov <pva@g.o> wrote: |
2 | > В Пнд, 27/09/2010 в 11:37 +0000, Dirkjan Ochtman (djc) пишет: |
3 | >> src_compile() { |
4 | >> use static && sed -i -e '/^LIBS/s/LIBS = /LIBS = -static /' Makefile |
5 | >> |
6 | >> emake || die "make failed" |
7 | >> |
8 | >> if ! use minimal ; then |
9 | >> cd plugin |
10 | >> for i in $( ls 2>/dev/null ); do |
11 | > |
12 | > This is bad construction: |
13 | > http://mywiki.wooledge.org/BashPitfalls#for_i_in_.24.28ls_.2A.mp3.29 |
14 | > |
15 | |
16 | A nice way around this is to do the following: |
17 | |
18 | ls -1 | while read i; do |
19 | |
20 | `read` delimits on newline, so you're safe. |
21 | |
22 | -- |
23 | ~Nirbheek Chauhan |
24 | |
25 | Gentoo GNOME+Mozilla Team |
Subject | Author |
---|---|
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild | Ryan Hill <dirtyepic@g.o> |
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild | Jeroen Roovers <jer@g.o> |