Gentoo Archives: gentoo-dev

From: James Cloos <cloos@×××××××.com>
To: Kent Fredric <kentfredric@×××××.com>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] new eclass proposal, perl-mb-tiny.eclass
Date: Tue, 03 Sep 2013 23:37:46
Message-Id: m3txi18oq3.fsf@carbon.jhcloos.org
In Reply to: [gentoo-dev] new eclass proposal, perl-mb-tiny.eclass by Kent Fredric
1 Please eliminate the call to perl_delete_module_manpages.
2
3 perl-module.eclass's malicious abuse of that should not propagate.
4
5 The man pages are as valuable as the modules themselves.
6
7 I wonder about:
8
9 if [[ -z ${mytargets} ]] ; then
10 case "${CATEGORY}" in
11 dev-perl|perl-core) mytargets="install" ;;
12 *) mytargets="install" ;;
13 esac
14 fi
15
16 Did the case block originally have different results for different CATEGORYs?
17
18 Otherwise it looks good. And useful.
19
20 -JimC
21 --
22 James Cloos <cloos@×××××××.com> OpenPGP: 1024D/ED7DAEA6