Re: [gentoo-dev] [PATCH] java-utils-2.eclass: remove ebegin calls that lack eend calls

[David Seifert]

On Fri, 2022-04-15 at 10:11 -0400, Mike Gilbert wrote:
> Instead, echo the command we are about to run.
>
> Closes: https://bugs.gentoo.org/838475
> Closes: https://bugs.gentoo.org/838478
> Closes: https://bugs.gentoo.org/838481
> Closes: https://bugs.gentoo.org/838487
> Closes: https://bugs.gentoo.org/838490
> Closes: https://bugs.gentoo.org/838493
> Signed-off-by: Mike Gilbert <floppym@g.o>
> ---
>  eclass/java-utils-2.eclass | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/eclass/java-utils-2.eclass b/eclass/java-utils-2.eclass
> index 11798908dae..2a649942550 100644
> --- a/eclass/java-utils-2.eclass
> +++ b/eclass/java-utils-2.eclass
> @@ -2099,8 +2099,9 @@ ejavac() {
>                 einfo "${compiler_executable} ${javac_args} ${@}"
>         fi
>  
> -       ebegin "Compiling"
> -       ${compiler_executable} ${javac_args} "${@}" || die "ejavac
> failed"
> +       local args=( ${compiler_executable} ${javac_args} "${@}" )
> +       echo "${args[@]}" >&2
> +       "${args[@]}" || die "ejavac failed"
>  }
>  
>  # @FUNCTION: ejavadoc
> @@ -2125,8 +2126,9 @@ ejavadoc() {
>                 einfo "javadoc ${javadoc_args} ${@}"
>         fi
>  
> -       ebegin "Generating JavaDoc"
> -       javadoc ${javadoc_args} "${@}" || die "ejavadoc failed"
> +       local args=( javadoc ${javadoc_args} "${@}" )
> +       echo "${args[@]}" >&2
> +       "${args[@]}" || die "ejavadoc failed"
>  }
>  
>  # @FUNCTION: java-pkg_filter-compiler

Another nice example of "edo" being reinvented. LGTM