| 1 |
El sáb, 20-10-2018 a las 18:59 -0700, Zac Medico escribió: |
| 2 |
> On 10/20/2018 04:21 AM, Pacho Ramos wrote: |
| 3 |
> > It seems that random values in GOBIN can affect the building of some |
| 4 |
> > packages: |
| 5 |
> > https://bugs.gentoo.org/631776 |
| 6 |
> > https://bugs.gentoo.org/636506 |
| 7 |
> > https://bugs.gentoo.org/638572 |
| 8 |
> > |
| 9 |
> > I would then append it to ENV_UNSET in make.defaults to get that variable |
| 10 |
> > unset |
| 11 |
> > without needing to do the same for every ebuild that could be affected by |
| 12 |
> > this |
| 13 |
> > |
| 14 |
> > Any issues against this? |
| 15 |
> |
| 16 |
> Seems reasonable, since the only purpose of GOBIN is to override the |
| 17 |
> directory where 'go install' will install a command. If we unset it |
| 18 |
> unconditionally, it means that the location will predictably default to |
| 19 |
> GOPATH/bin, which is exactly what we want. |
| 20 |
> |
| 21 |
> We could handle it in the golang-build_src_install function, but that |
| 22 |
> wouldn't cover things that call 'go install' via a script or Makefile. |
| 23 |
> |
| 24 |
> > Thanks |
| 25 |
> > |
| 26 |
|
| 27 |
Done: |
| 28 |
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c06caedd7c6bb91be0b8e963eb2 |
| 29 |
cb98e74448f67 |
Archives