1 |
On Wed, Aug 14, 2019, 5:26 PM Michał Górny <mgorny@g.o> wrote: |
2 |
|
3 |
> On Wed, 2019-08-14 at 17:14 -0400, Mike Gilbert wrote: |
4 |
> > Closes: https://bugs.gentoo.org/691478 |
5 |
> > Signed-off-by: Mike Gilbert <floppym@g.o> |
6 |
> > --- |
7 |
> > eclass/acct-user.eclass | 5 +++++ |
8 |
> > 1 file changed, 5 insertions(+) |
9 |
> > |
10 |
> > diff --git a/eclass/acct-user.eclass b/eclass/acct-user.eclass |
11 |
> > index 60009643c144..cec5d0506879 100644 |
12 |
> > --- a/eclass/acct-user.eclass |
13 |
> > +++ b/eclass/acct-user.eclass |
14 |
> > @@ -334,6 +334,11 @@ acct-user_pkg_preinst() { |
15 |
> > if [[ -z ${ACCT_USER_HOME_OWNER} ]]; then |
16 |
> > |
17 |
> ACCT_USER_HOME_OWNER=${ACCT_USER_NAME}:${ACCT_USER_GROUPS[0]} |
18 |
> > fi |
19 |
> > + # Path might be missing due to INSTALL_MASK, etc. |
20 |
> > + # https://bugs.gentoo.org/691478 |
21 |
> > + if [[ ! -e "${ED}/${ACCT_USER_HOME#/}" ]]; then |
22 |
> > + keepdir "${ACCT_USER_HOME}" |
23 |
> > + fi |
24 |
> |
25 |
> Doesn't it violate the principle of least surprise if you recreate |
26 |
> the path that user intentionally wanted stripped? |
27 |
> |
28 |
> > fowners "${ACCT_USER_HOME_OWNER}" "${ACCT_USER_HOME}" |
29 |
> > fperms "${ACCT_USER_HOME_PERMS}" "${ACCT_USER_HOME}" |
30 |
> > fi |
31 |
> |
32 |
> -- |
33 |
> Best regards, |
34 |
> Michał Górny |
35 |
> |
36 |
|
37 |
I was debating that with myself after I sent this. I suppose we could just |
38 |
skip it if it is missing. |
39 |
|
40 |
> |