Archives
Archives
| From: | Ulrich Mueller <ulm@g.o> | ||
|---|---|---|---|
| To: | Thomas Bracht Laumann Jespersen <t@×××××××.xyz> | ||
| Cc: | gentoo-dev@l.g.o, kernel@g.o, Sam James <sam@g.o> | ||
| Subject: | Re: [gentoo-dev] [PATCH] linux-info.eclass: Call ebegin, properly close with eend | ||
| Date: | Wed, 13 Apr 2022 09:52:33 | ||
| Message-Id: | u8rs9wbsn@gentoo.org | ||
| In Reply to: | [gentoo-dev] [PATCH] linux-info.eclass: Call ebegin, properly close with eend by Thomas Bracht Laumann Jespersen |
||
| 1 | >>>>> On Wed, 13 Apr 2022, Thomas Bracht Laumann Jespersen wrote: |
| 2 | |
| 3 | > - einfo "Checking for suitable kernel configuration options..." |
| 4 | > + ebegin "Checking for suitable kernel configuration options..." |
| 5 | |
| 6 | ebegin outputs dots by itself, so the ones in the message should be |
| 7 | removed. |
| 8 | |
| 9 | > elif [[ ${soft_errors_count} -gt 0 ]]; then |
| 10 | > + eend 0 |
| 11 | > ewarn "Please check to make sure these options are set correctly." |
| 12 | > ewarn "Failure to do so may cause unexpected problems." |
| 13 | |
| 14 | Shouldn't this be eend 1, given that there are errors? |
| 15 | |
| 16 | Ulrich |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] [PATCH] linux-info.eclass: Call ebegin, properly close with eend | Thomas Bracht Laumann Jespersen <t@×××××××.xyz> |