Gentoo Archives: gentoo-dev

From: Ian Stakenvicius <axs@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] patch eutils.eclass for EAPI 5
Date: Thu, 27 Sep 2012 17:17:46
Message-Id: 506489FD.50203@gentoo.org
In Reply to: Re: [gentoo-dev] patch eutils.eclass for EAPI 5 by Zac Medico
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 27/09/12 01:07 PM, Zac Medico wrote:
5 > On 09/27/2012 09:49 AM, Ulrich Mueller wrote:
6 >> As far as I can see, only the definition of the usex function
7 >> must be disabled. Please review the patch included below.
8 >>
9 >> Ulrich
10 >>
11 >> --- eutils.eclass 15 Sep 2012 16:16:53 -0000 1.403 +++
12 >> eutils.eclass 27 Sep 2012 16:45:14 -0000 @@ -1373,7 +1373,9 @@ #
13 >> @DESCRIPTION: # If USE flag is set, echo [true output][true
14 >> suffix] (defaults to "yes"), # otherwise echo [false
15 >> output][false suffix] (defaults to "no"). +if has "${EAPI:-0}" 0
16 >> 1 2 3 4; then usex() { use "$1" && echo "${2-yes}$4" || echo
17 >> "${3-no}$5" ; } #382963 +fi
18 >>
19 >> # @FUNCTION: prune_libtool_files # @USAGE: [--all]
20 >>
21 >
22 > Looks good to me.
23 >
24 > It may not work for unofficial EAPIs that don't include usex, but
25 > I guess there's nothing we can do for those, and they can just be
26 > replaced with newer EAPIs that include usex.
27
28 ....i actually just committed the fix discussed in #gentoo-dev , using
29 'declare -F' instead (similar to the eqawarn conditional declaration
30 already in eutils.eclass)
31
32
33 Sorry..
34
35 -----BEGIN PGP SIGNATURE-----
36 Version: GnuPG v2.0.19 (GNU/Linux)
37
38 iF4EAREIAAYFAlBkif0ACgkQ2ugaI38ACPDcvgEAudN0ErAB8aZkjtdiTK309NV0
39 01UWERp6vSQsvTmaVUwA/1LBd9ddbgGUpiqwvDCYzYR1rbgiA+7a6vzU9mmzZpil
40 =RdnN
41 -----END PGP SIGNATURE-----

Replies

Subject Author
Re: [gentoo-dev] patch eutils.eclass for EAPI 5 Zac Medico <zmedico@g.o>
Re: [gentoo-dev] patch eutils.eclass for EAPI 5 Jeroen Roovers <jer@g.o>