| 1 |
On 11/01/2018 06:27 PM, Andrew Savchenko wrote: |
| 2 |
> |
| 3 |
> This eclass is small, so no harm here. But for larger eclasses |
| 4 |
> (hello java-*.eclass) this will hinder updates considerably. I |
| 5 |
> prefer to fix something rather than to fix nothing while |
| 6 |
> frustrating in attempt to fix everything at once. |
| 7 |
> |
| 8 |
> Also this make git history review harder as fixes for independent |
| 9 |
> issues will be mixed together. |
| 10 |
> |
| 11 |
> So I kindly ask you for future updates (from everyone, not just |
| 12 |
> me) focus on review of the proposed changes instead of reviewing |
| 13 |
> full code. Thank you for understanding. |
| 14 |
> |
| 15 |
|
| 16 |
You don't have to fix everything at once. A thorough code review is |
| 17 |
incredibly valuable we shouldn't discourage anyone from doing them. |
| 18 |
|
| 19 |
On the other hand, if you decide to fix only some of the issues, that's |
| 20 |
your prerogative. I would however suggest that afterwards, you open a |
| 21 |
bug for the remaining improvements so that the valuable time of the |
| 22 |
reviewer is not wasted. |
Archives