Gentoo Archives: gentoo-dev

From: Zac Medico <zmedico@g.o>
To: "Michał Górny" <mgorny@g.o>, gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [RFC] Moving COLLISION_IGNORE (and UNINSTALL_IGNORE?) to profiles/*/make.defaults
Date: Fri, 09 Aug 2013 18:46:23
Message-Id: 520538F9.80600@gentoo.org
In Reply to: Re: [gentoo-dev] [RFC] Moving COLLISION_IGNORE (and UNINSTALL_IGNORE?) to profiles/*/make.defaults by "Michał Górny"
1 On 08/09/2013 11:10 AM, Michał Górny wrote:
2 > Dnia 2013-08-09, o godz. 09:47:38
3 > Zac Medico <zmedico@g.o> napisał(a):
4 >
5 >> On 08/09/2013 02:32 AM, Michał Górny wrote:
6 >>> Hello,
7 >>>
8 >>> Just a quick one.
9 >>>
10 >>> Currently, the two listed variables are set in make.globals (installed
11 >>> by portage ebuild);
12 >>>
13 >>> COLLISION_IGNORE="/lib/modules/* *.py[co] *\$py.class"
14 >>> UNINSTALL_IGNORE="/lib/modules/*"
15 >>>
16 >>> COLLISION_IGNORE specifies files that will be ignored by
17 >>> FEATURES=collision-protect when they exist but are not owned by any
18 >>> package. UNINSTALL_IGNORE specifies files that will not be unmerged.
19 >>>
20 >>> By keeping those two in portage, we're basically binding them to
21 >>> version of portage installed. If we need to ignore more files, we need
22 >>> to request our users to upgrade portage.
23 >>>
24 >>> That's why I'm thinking of moving them to profiles/base/make.defaults.
25 >>> From what I've tested, the setting there will override make.globals
26 >>> and therefore the change could be effective from day one, without
27 >>> the need to upgrade portage.
28 >>>
29 >>> I feel like those variables are much alike the QA variables that we
30 >>> keep in the profiles.
31 >>>
32 >>> What do you think?
33 >>
34 >> I guess it's fine. I would do it like this in order to respect the
35 >> portage default setting:
36 >>
37 >> COLLISION_IGNORE="${COLLISION_IGNORE} new stuff"
38 >
39 > Well, the intent was to put the current default in there, and drop it
40 > in next version of portage since it is specific to gx86 eclasses
41 > and ebuilds.
42
43 Well, the /lib/modules/* setting specifically complements portage's
44 UNINSTALL_IGNORE setting, so that would be one reason to inherit the
45 portage setting, in case portage changes its default config somehow.
46 --
47 Thanks,
48 Zac

Replies