Re: [gentoo-dev] [PATCH 1/8] virtualx.eclass: Use case/esac to handle supported EAPIs

[Davide Pesavento]

On Sat, Nov 28, 2015 at 2:24 PM, Justin Lecher <jlec@g.o> wrote:
> Signed-off-by: Justin Lecher <jlec@g.o>
> ---
>  eclass/virtualx.eclass | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
> index 5d27ed9..584fb29 100644
> --- a/eclass/virtualx.eclass
> +++ b/eclass/virtualx.eclass
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2012 Gentoo Foundation
> +# Copyright 1999-2015 Gentoo Foundation
>  # Distributed under the terms of the GNU General Public License v2
>  # $Id$
>
> @@ -9,6 +9,17 @@
>  # Original author: Martin Schlemmer <azarah@g.o>
>  # @BLURB: This eclass can be used for packages that needs a working X environment to build.
>
> +case "${EAPI:-0}" in
> +       0|1)
> +               die "virtualx eclass require EAPI=2 or newer."

require -> requires

[nitpicking, feel free to ignore] Technically "2 or newer" is not
correct and not future-proof. You can rephrase to something like
"virtualx.eclass: EAPI ${EAPI} is too old".