Re: [gentoo-dev] [PATCH] toolchain.eclass (do_gcc_CYGWINPORTS_patches): avoid bash-4.4ism

[Sergei Trofimovich]

On Thu,  8 Aug 2019 12:53:37 +0200
Michael Haubenwallner <haubi@g.o> wrote:

> Closes: https://bugs.gentoo.org/690686
> ---
>  eclass/toolchain.eclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Looks good!

> diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
> index 6bc04b4cbfe..40d46ed0707 100644
> --- a/eclass/toolchain.eclass
> +++ b/eclass/toolchain.eclass
> @@ -687,9 +687,9 @@ do_gcc_CYGWINPORTS_patches() {
>  	[[ -n ${CYGWINPORTS_GITREV} ]] || return 0
>  	use elibc_Cygwin || return 0
>
> -	local -a patches
>  	local p d="${WORKDIR}/gcc-${CYGWINPORTS_GITREV}"
> -	readarray -t patches < <(sed -e '1,/PATCH_URI="/d;/"/,$d' < "${d}"/gcc.cygport)
> +	# readarray -t is available since bash-4.4 only, #690686
> +	local patches=( $(sed -e '1,/PATCH_URI="/d;/"/,$d' < "${d}"/gcc.cygport) )
>  	for p in ${patches[*]}; do
>  		epatch "${d}/${p}"
>  	done
> --
> 2.21.0
>
>


-- 

  Sergei