Gentoo Archives: gentoo-dev

From: Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o>
To: Gentoo Development <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass
Date: Mon, 05 Jul 2010 17:02:22
Message-Id: 201007051901.53098.Arfrever@gentoo.org
In Reply to: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass by "Tomáš Chvátal"
2010-07-05 18:36:09 Tomáš Chvátal napisał(a):
> Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a): > > 2010-07-05 18:26:40 Samuli Suominen napisał(a): > >> On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote: > >>> 2010-07-05 18:13:26 Samuli Suominen napisał(a): > >>>> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote: > >>>>> These minor changes in python.eclass and distutils.eclass have been already > >>>>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar > >>>>> with internals of current code before trying to understand these minor changes. > >>>>> Suggestions about indentation and quoting will be rejected. > >>>>> > >>>> > >>>> You have been already told to get rid of all the color customizations in > >>>> the python eclasses here: > >>>> > >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2 > >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3 > >>>> > >>>> [ .. ] > >>>> > >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5 > >>>> > >>>> The bug was wrongly closed as fixed, as it's not really fixed before > >>>> it's all punted > >>> > >>> Colors can be used with echo. > >>> > >> > >> Stop using echo for output and switch to standard output functions, like > >> einfo/eerror/elog/... like told in > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5 > > > > You should read relevant part of comment #7: > > "The colors can of course be continued to be used in outputs that are purely build > > time outputting and not for communicating things for users like what cmake builds do." > > > > python.eclass uses colors for build time outputting, which doesn't communicate anything for users. > > > + echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON > variable is deprecated and will be banned on 2010-10-01.${_NORMAL}" > + echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of > NEED_PYTHON variable.${_NORMAL}" > + echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please > report a bug, if it has not been already reported.${_NORMAL}" > > The above is build outputting since when?
The colored, non-logged output in deprecation warnings is used as exception to increase the chance that ebuild maintainers will be notified earlier about the necessity of changes in given ebuilds. -- Arfrever Frehtes Taifersar Arahesis

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass "Harald van Dijk" <truedfx@g.o>