Archives
Archives
| From: | Tom Wijsman <TomWij@g.o> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libsdl2/files: libsdl2-2.0.3-static-libs.patch | ||
| Date: | Mon, 12 May 2014 17:46:48 | ||
| Message-Id: | 20140512194627.1ad1ffda@gentoo.org | ||
| In Reply to: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libsdl2/files: libsdl2-2.0.3-static-libs.patch by Samuli Suominen |
||
| 1 | On Mon, 12 May 2014 18:59:33 +0300 |
| 2 | Samuli Suominen <ssuominen@g.o> wrote: |
| 3 | |
| 4 | > > - $(LIBTOOL) --mode=link $(CC) -o $@ $(OBJECTS) |
| 5 | > > $(VERSION_OBJECTS) $(LDFLAGS) $(EXTRA_LDFLAGS) $(LT_LDFLAGS) |
| 6 | > > + $(LIBTOOL) --mode=link $(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) |
| 7 | > > $(EXTRA_LDFLAGS) $(LT_LDFLAGS) |
| 8 | > |
| 9 | > You know that adding $(LDFLAGS) so late in the linker line makes whole |
| 10 | > -Wl,--as-needed get ignored? Should almost certainly be $(CC) |
| 11 | > $(LDFLAGS) $(CFLAGS) ... |
| 12 | |
| 13 | If someone wants an detailed explanation, see for reference: |
| 14 | |
| 15 | https://wiki.gentoo.org/wiki/Project:Quality_Assurance/As-needed#Importance_of_linking_order |
| 16 | |
| 17 | If someone wants emerge to bail out when it is wrong, see for reference: |
| 18 | |
| 19 | https://wiki.gentoo.org/wiki/Project:Quality_Assurance/As-needed#Forced_--as-needed |
| 20 | |
| 21 | IMPORTANT: There is a particular bug with these instructions: |
| 22 | |
| 23 | https://bugs.gentoo.org/show_bug.cgi?id=509966 |
| 24 | |
| 25 | A temporary solution is to remove the last GCC_SPECS="" line. |
| 26 | |
| 27 | -- |
| 28 | With kind regards, |
| 29 | |
| 30 | Tom Wijsman (TomWij) |
| 31 | Gentoo Developer |
| 32 | |
| 33 | E-mail address : TomWij@g.o |
| 34 | GPG Public Key : 6D34E57D |
| 35 | GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |