Re: [gentoo-dev] [PATCH 6/9] ruby-ng-gnome2.eclass: implement common test code

[Michał Górny]

On Sat, 2020-02-15 at 21:18 +0900, Naohiro Aota wrote:
> Fold common test code from runy-gnome2 ebuild to this eclass.
>
> To support test under virtx, introduce RUBY_GNOME2_NEED_VIRTX variable.
>
> Signed-off-by: Naohiro Aota <naota@g.o>
> ---
>  eclass/ruby-ng-gnome2.eclass | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/eclass/ruby-ng-gnome2.eclass b/eclass/ruby-ng-gnome2.eclass
> index dc48a53c58cd..1cc3cdce4ce6 100644
> --- a/eclass/ruby-ng-gnome2.eclass
> +++ b/eclass/ruby-ng-gnome2.eclass
> @@ -24,7 +24,16 @@ RUBY_FAKEGEM_NAME="${RUBY_FAKEGEM_NAME:-${PN#ruby-}}"
>  RUBY_FAKEGEM_TASK_TEST=""
>  RUBY_FAKEGEM_TASK_DOC=""
>
> +# @ECLASS-VARIABLE: RUBY_GNOME2_NEED_VIRTX

@PRE_INHERIT

> +# @DESCRIPTION:
> +# If set to 'yes', the test is run with virtx. Set before inheriting this
> +# eclass.
> +: ${RUBY_GNOME2_NEED_VIRTX:="no"}
> +
>  inherit ruby-fakegem multilib versionator
> +if [[ ${RUBY_GNOME2_NEED_VIRTX} == yes ]]; then
> +	inherit virtualx
> +fi
>
>  IUSE=""
>
> @@ -88,3 +97,16 @@ all_ruby_install() {
>
>  	all_fakegem_install
>  }
> +
> +# @FUNCTION: each_ruby_test
> +# @DESCRIPTION:
> +# Run the tests for this package.
> +each_ruby_test() {
> +	test -e test/run-test.rb || return

Don't use test in bash, use [[.

> +
> +	if [[ ${RUBY_GNOME2_NEED_VIRTX} == yes ]]; then
> +		virtx ${RUBY} test/run-test.rb || die

Doesn't virtx die for you?

> +	else
> +		${RUBY} test/run-test.rb || die
> +	fi
> +}

-- 
Best regards,
Michał Górny