Gentoo Archives: gentoo-dev

From: "Marijn Schouten (hkBst)" <hkBst@g.o>
To: Donnie Berkholz <dberkholz@g.o>
Cc: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-scheme/bigloo: ChangeLog bigloo-3.0b_p2.ebuild
Date: Tue, 25 Sep 2007 10:53:40
Message-Id: 46F8E747.5090902@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-scheme/bigloo: ChangeLog bigloo-3.0b_p2.ebuild by Donnie Berkholz
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 Donnie Berkholz wrote:
5 > On 12:35 Mon 24 Sep , Marijn Schouten (hkbst) wrote:
6 >> hkbst 07/09/24 12:35:11
7 >>
8 >> Modified: ChangeLog
9 >> Added: bigloo-3.0b_p2.ebuild
10 >> Log:
11 >> bump 3.0b-2, minor bugfix version
12 >> (Portage version: 2.1.3.9)
13 >
14 >> # "make test" does something weird so default src_test() in /usr/lib/portage/bin/ebuild.sh fails the following test
15 >> # elif emake -j1 test -n &> /dev/null; then
16 >> # so copy straight from default src_test() all the stuff which depends on that test passing
17 >> src_test() {
18 >> vecho ">>> Test phase [test]: ${CATEGORY}/${PF}"
19 >> if ! emake -j1 test; then
20 >> hasq test $FEATURES && die "Make test failed. See above for details."
21 >> hasq test $FEATURES || eerror "Make test failed. See above for details."
22 >> fi
23 >> }
24 >
25 > I'm a bit confused about what's going on here. Isn't src_test() only
26 > supposed to run when 'test' is in FEATURES?
27
28 I'm not sure, but as the comment says, I copied this straight from
29 /usr/lib/portage/bin/ebuild.sh and it goes:
30
31 src_test() {
32 if emake -j1 check -n &> /dev/null; then
33 vecho ">>> Test phase [check]: ${CATEGORY}/${PF}"
34 if ! emake -j1 check; then
35 hasq test $FEATURES && die "Make check failed. See
36 above for details."
37 hasq test $FEATURES || eerror "Make check failed. See
38 above for details."
39 fi
40 elif emake -j1 test -n &> /dev/null; then
41 vecho ">>> Test phase [test]: ${CATEGORY}/${PF}"
42 if ! emake -j1 test; then
43 hasq test $FEATURES && die "Make test failed. See
44 above for details."
45 hasq test $FEATURES || eerror "Make test failed. See
46 above for details."
47 fi
48 else
49 vecho ">>> Test phase [none]: ${CATEGORY}/${PF}"
50 fi
51 }
52
53 Marijn
54
55 PS Thank you for reviewing, Donnie.
56
57 - --
58 Marijn Schouten (hkBst), Gentoo Lisp project
59 <http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
60 -----BEGIN PGP SIGNATURE-----
61 Version: GnuPG v2.0.7 (GNU/Linux)
62 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
63
64 iD8DBQFG+OdHp/VmCx0OL2wRApSBAKCCw8MZPTXuKlbswqYhKxKKrVlggQCgw2FM
65 OLDCy2QA4DV2tJFED2OFZt4=
66 =JAnZ
67 -----END PGP SIGNATURE-----
68 --
69 gentoo-dev@g.o mailing list

Replies