1 |
Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o> said: |
2 |
> 2010-07-05 18:26:40 Samuli Suominen napisał(a): |
3 |
> > On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote: |
4 |
> > > 2010-07-05 18:13:26 Samuli Suominen napisał(a): |
5 |
> > >> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote: |
6 |
> > >>> These minor changes in python.eclass and distutils.eclass have been already |
7 |
> > >>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar |
8 |
> > >>> with internals of current code before trying to understand these minor changes. |
9 |
> > >>> Suggestions about indentation and quoting will be rejected. |
10 |
> > >>> |
11 |
> > >> |
12 |
> > >> You have been already told to get rid of all the color customizations in |
13 |
> > >> the python eclasses here: |
14 |
> > >> |
15 |
> > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2 |
16 |
> > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3 |
17 |
> > >> |
18 |
> > >> [ .. ] |
19 |
> > >> |
20 |
> > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5 |
21 |
> > >> |
22 |
> > >> The bug was wrongly closed as fixed, as it's not really fixed before |
23 |
> > >> it's all punted |
24 |
> > > |
25 |
> > > Colors can be used with echo. |
26 |
> > > |
27 |
> > |
28 |
> > Stop using echo for output and switch to standard output functions, like |
29 |
> > einfo/eerror/elog/... like told in |
30 |
> > http://bugs.gentoo.org/show_bug.cgi?id=309057#c5 |
31 |
> |
32 |
> You should read relevant part of comment #7: |
33 |
> "The colors can of course be continued to be used in outputs that are purely build |
34 |
> time outputting and not for communicating things for users like what cmake builds do." |
35 |
> |
36 |
> python.eclass uses colors for build time outputting, which doesn't communicate anything for users. |
37 |
|
38 |
Everyone else has already made valid points. I'm just picking this one |
39 |
to reply to now. Please remove the colors you have added. If you need |
40 |
a new function, say "eqawarn", we should have that added in the next |
41 |
EAPI with a description of when and where to use it. In the meantime, |
42 |
Petteri proposed a nice solution awhile back that would centralize this |
43 |
so it is not a one-off hack. Here is a link to his original proposal: |
44 |
|
45 |
http://archives.gentoo.org/gentoo-dev/msg_44d395a1b887468051a1e1c049e99ba3.xml |
46 |
|
47 |
Thanks, |
48 |
|
49 |
-- |
50 |
Mark Loeser |
51 |
email - halcy0n AT gentoo DOT org |
52 |
email - mark AT halcy0n DOT com |
53 |
web - http://www.halcy0n.com |