1 |
Donnie Berkholz wrote: |
2 |
> On 06:58 Fri 21 Sep , Alistair Bush wrote: |
3 |
>> normally java-pkg_do_write_ is called to write the package.env out, as |
4 |
>> can be seen, and is the default behavior for the function. What I am |
5 |
>> adding is the ability to _do_write of a "[virtual|provider].env" file. |
6 |
>> While at present it only contains 3 variables, I see no reason why |
7 |
>> eventually it will not include other vars that are shared between the |
8 |
>> package.env and "virtual.env" ( e.g DESCRIPTION ) |
9 |
>> |
10 |
>> Therefore this change can be summarized as |
11 |
>> |
12 |
>> + if [[ $1 != provider ]]; then |
13 |
>> #Do the default package.env behaviour |
14 |
>> + else |
15 |
>> + #Create a "virtual.env" file. This will only be invoked by |
16 |
>> + #ebuilds that inherit java-virtuals.eclass |
17 |
>> + fi |
18 |
>> |
19 |
>> I could very well reflactor the java-pkg_do_write_ function back to its |
20 |
>> current state and create a new function java-pkg_do_write_virtual to be |
21 |
>> called by java-virtuals-2.eclass. |
22 |
>> |
23 |
>> The documentation could (and will) be updated to more correctly reflect |
24 |
>> whats happening. |
25 |
> |
26 |
> I'm concerned about code duplication, because that's what it looks like. |
27 |
> Refactoring might be a good idea. |
28 |
> |
29 |
> Thanks, |
30 |
> Donnie |
31 |
|
32 |
Ok, thanks for the input Donnie. I will refactor it before goes into the |
33 |
tree. |
34 |
|
35 |
Any more input ppl? |
36 |
|
37 |
Thanks |
38 |
|
39 |
Alistair |
40 |
-- |
41 |
gentoo-dev@g.o mailing list |