Re: [gentoo-dev] [PATCH] eclass: freedict: require EAPI=6

[Marty E. Plummer]

On Tue, Mar 27, 2018 at 11:20:08AM +0200, Ulrich Mueller wrote:
> While at it:
> - Drop the IUSE="" assignment, it is useless (pun intended :)
> - Update HOMEPAGE, freedict.de is dead
> - LICENSE should be "GPL-2+" (sources say "GNU General Public License
>   ver. 2.0 and any later version")
> - DEPEND is not needed (should be RDEPEND instead, I guess)
> - Use canonical ordering of variables (DESCRIPTION, HOMEPAGE, SRC_URI
>   in first block; LICENSE, SLOT in second; then dependencies; then S)
>
> Ulrich
>
How's this:

---
 eclass/freedict.eclass | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/eclass/freedict.eclass b/eclass/freedict.eclass
index 06419626d34..7c598aa6eaf 100644
--- a/eclass/freedict.eclass
+++ b/eclass/freedict.eclass
@@ -1,4 +1,4 @@
-# Copyright 1999-2014 Gentoo Foundation
+# Copyright 1999-2018 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
 
 # @ECLASS: freedict.eclass
@@ -21,21 +21,23 @@
 # @DESCRIPTION:
 # Please see above for a description.
 
-inherit eutils multilib
-
-IUSE=""
+case ${EAPI:-0} in
+	6) ;;
+	*) die "${ECLASS}.eclass is banned in EAPI=${EAPI}" ;;
+esac
 
 MY_P=${PN/freedict-/}
 
-S="${WORKDIR}"
 DESCRIPTION="Freedict for language translation from ${FORLANG} to ${TOLANG}"
-HOMEPAGE="http://www.freedict.de"
+HOMEPAGE="http://freedict.sourceforge.net"
 SRC_URI="http://freedict.sourceforge.net/download/linux/${MY_P}.tar.gz"
 
+LICENSE="GPL-2+"
 SLOT="0"
-LICENSE="GPL-2"
 
-DEPEND="app-text/dictd"
+RDEPEND="app-text/dictd"
+
+S="${WORKDIR}"
 
 # @FUNCTION: freedict_src_install
 # @DESCRIPTION:
-- 
2.16.3