Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>, zmedico@g.o
Subject: Re: [gentoo-dev] RFC: [Future EAPI] Exporting phase funcs from direct inherits only
Date: Sat, 18 Aug 2012 03:22:06
Message-Id: 201208172320.30720.vapier@gentoo.org
In Reply to: Re: [gentoo-dev] RFC: [Future EAPI] Exporting phase funcs from direct inherits only by "Michał Górny"
1 On Tuesday 14 August 2012 16:39:57 Michał Górny wrote:
2 > On Tue, 14 Aug 2012 12:46:30 -0700 Zac Medico wrote:
3 > > On 08/14/2012 02:44 AM, Michał Górny wrote:
4 > > > As some of you may have noticed, lately introduced 'double include
5 > > > preventions' have caused changes in effective phase functions in a
6 > > > few ebuilds.
7 > >
8 > > Can't that be avoided by putting the EXPORT_FUNCTIONS call outside of
9 > > the ifndef block? The function implementations themselves can be
10 > > inside the ifndef block, since that only need to be sourced once.
11 >
12 > Isn't that an awful kind of undefined behavior? We're already
13 > on a slippery ground assuming that sourced data changes between
14 > inherits. Assuming EXPORT_FUNCS will work some other ugly way is even
15 > worse.
16
17 the "other way" is "the way EXPORT_FUNCS has always worked", so it's not like
18 it's anything new for people to wrassl' with
19 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature